Add waypoints to replay#2786
Merged
Merged
Conversation
d35f4e1 to
3372934
Compare
3372934 to
0711b93
Compare
Codecov Report
@@ Coverage Diff @@
## master #2786 +/- ##
=========================================
Coverage 35.14% 35.14%
Complexity 2100 2100
=========================================
Files 540 540
Lines 19260 19260
Branches 1819 1819
=========================================
Hits 6769 6769
Misses 11681 11681
Partials 810 810 |
This was referenced Apr 17, 2020
Guardiola31337
approved these changes
Apr 17, 2020
Contributor
Guardiola31337
left a comment
There was a problem hiding this comment.
Looking good 🚀
As you can notice 👇 notification is stuck when arriving to the first destination (You have arrived) and there's a maneuver arrow displayed (behind the notification 😅) when shouldn't cc'ing @cafesilencio as this seems a regression from NavigationMapboxMap
In any case, we're able to reproduce the multi-leg issues and start tackling them 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Starting with the minimum to add waypoint support to replay. So I can support replay waypoints #2766
bug,feature,new API(s),SEMVER, etc.)Screenshots or Gifs
Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR