Add custom segue example.#113
Merged
Merged
Conversation
MaximAlien
changed the base branch from
release-v2.0
to
maxim/update-to-latest-mapbox-navigation
MaximAlien
force-pushed
the
maxim/custom-segue-example
branch
2 times, most recently
from
6292994 to
035c6b7
Compare
Comment on lines
+33
to
+34
| - MapboxCoreNavigation (from `https://github.com/mapbox/mapbox-navigation-ios.git`, branch `maxim/2973-fix-navigation-view-controller-crash-in-storyboard`) | ||
| - MapboxNavigation (from `https://github.com/mapbox/mapbox-navigation-ios.git`, branch `maxim/2973-fix-navigation-view-controller-crash-in-storyboard`) |
Contributor
There was a problem hiding this comment.
We should base off of release-v2.0 branch or tagged release after this fix is merged.
Contributor
Author
There was a problem hiding this comment.
Yep, updated to release-v2.0 for now.
Contributor
|
Looks good, but the transition is a little glitchy at start up for some examples. Some of the map layers seem to flash: customSegueGlitchy.mp4 |
jill-cardamon
approved these changes
May 26, 2021
Base automatically changed from
maxim/update-to-latest-mapbox-navigation
to
release-v2.0
May 27, 2021 05:18
MaximAlien
force-pushed
the
maxim/custom-segue-example
branch
from
860df94 to
5d1366d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom segue example, which allows to create
NavigationViewControllerfrom storyboard.