Use showcase(_:animated:) method to display route and destination for tutorial#143
Open
jill-cardamon wants to merge 2 commits into
Open
Use showcase(_:animated:) method to display route and destination for tutorial#143jill-cardamon wants to merge 2 commits into
showcase(_:animated:) method to display route and destination for tutorial#143jill-cardamon wants to merge 2 commits into
Conversation
1ec5
approved these changes
Sep 27, 2021
| // Show destination waypoint on the map | ||
| strongSelf.navigationMapView.showWaypoints(on: route) | ||
| // Showcase the route and destination waypoint, and set camera | ||
| strongSelf.navigationMapView.showcase([route], animated: true) |
Contributor
There was a problem hiding this comment.
While we’re at it, we might as well showcase all the routes in response.routes.
Contributor
Author
There was a problem hiding this comment.
Sure, thanks for the suggestion. I'll introduce navigationMapView(_ :didSelect:) delegate method, so the user can toggle between them.
Contributor
|
@jill-cardamon, are we ready to merge this one? Looks like everything is ready here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how we display the route and destination waypoint in the tutorial app. Previously, developers were shown
from comment.