fix setup && bugs #202
Open
chizhavko wants to merge 9 commits into
Open
Conversation
added 9 commits
November 22, 2022 15:37
Remove podfile, add dependencies via SPM
…vigating/Remove navigation mode like map style after close navigation mode
azarovalex
reviewed
Nov 23, 2022
| @@ -10,16 +10,14 @@ A collection of examples showing off the [Mapbox Navigation SDK](https://github. | |||
|
|
|||
| _Installation with CocoaPods_ | |||
Contributor
There was a problem hiding this comment.
Let's change to SPM now
azarovalex
reviewed
Nov 23, 2022
| 1. `git clone https://github.com/mapbox/mapbox-navigation-ios-examples.git` | ||
| 1. `cd mapbox-navigation-ios-examples` | ||
| 1. Open project and wait for couple of minutes. SPM need to load mapbox Navigation SDK dependencies. ☕️ | ||
| 1. Go to your [Mapbox account dashboard](https://account.mapbox.com/) and create an access token that has the `DOWNLOADS:READ` scope. **PLEASE NOTE: This is not the same as your production Mapbox API token. Make sure to keep it private and do not insert it into any Info.plist file.** Create a file named `.netrc` in your home directory if it doesn’t already exist, then add the following lines to the end of the file: |
Contributor
There was a problem hiding this comment.
This step should be done before a user tries to resolve packages, otherwise, SPM won't be able to download binary artifacts.
MaximAlien
reviewed
Nov 28, 2022
| lineLayer.lineCap = .constant(.round) | ||
|
|
||
| return lineLayer | ||
| func changeMapStyle(_ navigationMapView: NavigationMapView?) { |
Contributor
There was a problem hiding this comment.
Intention of this example is to showcase the ability to change route line styling via delegates. I'm not sure that we need this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Move project setup from cocoapods to spm
-Fix crashes
-Updated code base and improved examples with new SDK features
-Update readme