Upgrade to MapboxNavigationNative 14.1.5 #2417
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,8 +20,12 @@ open class RouteController: NSObject { | |
| public static let shouldPreventReroutesWhenArrivingAtWaypoint: Bool = true | ||
| public static let shouldDisableBatteryMonitoring: Bool = true | ||
| } | ||
|
|
||
| lazy var navigator: Navigator = { | ||
| let settingsProfile = SettingsProfile(application: ProfileApplication.kMobile, | ||
| platform: ProfilePlatform.KIOS) | ||
| return Navigator(profile: settingsProfile, customConfig: "") | ||
| }() | ||
|
|
||
| public var route: Route { | ||
| get { | ||
|
|
@@ -316,7 +320,7 @@ open class RouteController: NSObject { | |
| NotificationUserInfoKey.routeProgressKey: progress, | ||
| NotificationUserInfoKey.locationKey: location, //guaranteed value | ||
| NotificationUserInfoKey.rawLocationKey: rawLocation, //raw | ||
| ]) | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -387,7 +391,7 @@ extension RouteController: Router { | |
| } | ||
|
|
||
| let status = status ?? navigator.getStatusForTimestamp(location.timestamp) | ||
| let offRoute = status.routeState == .offRoute || status.routeState == .invalid | ||
|
Contributor
Author
There was a problem hiding this comment. As per discussion with @SiarheiFedartsou in Slack, for now it's better to treat |
||
| return !offRoute | ||
| } | ||
|
|
||
|
|
@@ -431,9 +435,6 @@ extension RouteController: Router { | |
| ]) | ||
| return | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various test fixtures are conditionalized by iOS version, based on their file names. So we’ll need to rename or delete and rerecord a slew of test fixtures, similar to what took place in #2427.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixtures were updated. I've also decided to remove iOS 13.4.1 build job since there is one for 13.5 already (this will allow to speed up build time and prevent adding additional fixtures for 13.4.1).