Implement a new method to change route#3159
Merged
Merged
Conversation
S2Ler
added
bug
S2Ler
force-pushed
the
s2ler/2948-reroute
branch
5 times, most recently
from
10ccf15 to
2adc051
Compare
Udumft
reviewed
Jul 19, 2021
S2Ler
force-pushed
the
s2ler/2948-reroute
branch
from
2adc051 to
7dbaf9a
Compare
Previous method of just updating `indexedRoute` wasn't robust enough for cases when the new route has different waypoints than the one it is replacing. New method allows to update route from the different set of waypoints. Fixes #2948
S2Ler
force-pushed
the
s2ler/2948-reroute
branch
from
7dbaf9a to
113a1dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2948
Previous method of just updating
indexedRoutewasn't robust enough forcases when the new route has different waypoints than the one it is
replacing. New method allows to update route from the different set of
waypoints.