Make NavigationService optional to be able to skip implementation of delegate method on client side.#3208
Merged
Merged
Conversation
MaximAlien
added
the
CarPlay
MaximAlien
added
the
UI
bamx23
approved these changes
Jul 28, 2021
…f delegate method on client side as `CarPlayManager` provides default `MapboxNavigationService` implementation anyway.
MaximAlien
force-pushed
the
maxim/make-navigation-service-optional
branch
from
2a6c1b7 to
0152381
Compare
MaximAlien
commented
Jul 28, 2021
| - returns: The actual trip to be previewed. This can be the same trip or a new/alternate trip if desired. | ||
| */ | ||
| func carPlayManager(_ carPlayManager: CarPlayManager, willPreview trip: CPTrip) -> (CPTrip) | ||
| func carPlayManager(_ carPlayManager: CarPlayManager, willPreview trip: CPTrip) -> CPTrip |
Contributor
Author
There was a problem hiding this comment.
Not sure why these delegate methods return tuple. Changed signature to return object instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
CarPlayManageralways provides defaultMapboxNavigationServiceimplementation there is no need to force user to provide another instance even if it's similar to the previous one.This is usability improvement, which was found during implementation of mapbox/mapbox-navigation-ios-examples#134.