Fix IndexedRouteResponse handling after rerouting

[OttyLab]

Summary

Reroute does not update indexedRouteResponse and refresh uses old route's identifier to update route annotations. This provides unexpected speed limit, congestion information display.

Detail

Reroute does not update indexedRouteResponse. indexedRouteResponse.routeResponse.identifier represents route's identifier and used when refreshing.

Therefore, indexedRouteResponse needs to be updated here.

Screenshot

After the reroute, speed limit shows 90km/h but 1 min later it becomes 70km/h. This road is 90km/h and 70km/h is wrong.

repro_s.mp4

Expected behavior

expected_s.mp4

[1ec5]

Thanks for contributing this fix! This PR includes some additional debugging code that would need to be cleaned up, but I went ahead and rolled your commit into #3345, which also includes more substantial changes in this area. Please have a look at that PR. Hopefully we can land the whole thing soon, but if not, then we can clean up this PR and merge it instead.

[1ec5]

On second thought, #3345 has amassed so many changes that we’re a bit wary of landing it literally right before v2.0.0-rc.1, so we’ll clean up this more targeted fix, land it for v2.0.0-rc.1, and land #3345 right after to squeeze in additional testing before v2.0.0-rc.2.

[1ec5]

This is correct for now. #3345 will change the behavior of the method that this closure is passed into, so that the closest matching route will no longer be guaranteed to be at index 0; instead, the closure will receive the index of the closest matching route.

[1ec5]

Updated the changelog in e68d748.