Skip to content

Deprecate custom usesMetric in favor of iOS defined usesMetricSystem#3547

Merged
S2Ler merged 2 commits into
mainfrom
feature/deprecate-uses-metric
Nov 11, 2021
Merged

Deprecate custom usesMetric in favor of iOS defined usesMetricSystem#3547
S2Ler merged 2 commits into
mainfrom
feature/deprecate-uses-metric

Conversation

@S2Ler
Copy link
Copy Markdown
Contributor

@S2Ler S2Ler commented Nov 2, 2021

iOS has standard usesMetricSystem variable that works differently for UK locale

@S2Ler S2Ler added this to the v2.1 milestone Nov 2, 2021
@S2Ler S2Ler self-assigned this Nov 2, 2021
@S2Ler S2Ler requested a review from a team November 2, 2021 07:46
@mapbox-github-ci-issues-3
Copy link
Copy Markdown

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-3
Copy link
Copy Markdown

No breaking changes detected in MapboxNavigation

Comment thread Sources/MapboxCoreNavigation/Locale.swift
Comment thread Sources/MapboxCoreNavigation/Locale.swift
@S2Ler S2Ler force-pushed the feature/deprecate-uses-metric branch from feece1d to f7c7c36 Compare November 3, 2021 15:52
@mapbox-github-ci-issues-5
Copy link
Copy Markdown

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-5
Copy link
Copy Markdown

No breaking changes detected in MapboxNavigation

@S2Ler S2Ler force-pushed the feature/deprecate-uses-metric branch from f7c7c36 to 7156c2c Compare November 4, 2021 06:35
@mapbox-github-ci-issues-5
Copy link
Copy Markdown

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-5
Copy link
Copy Markdown

No breaking changes detected in MapboxNavigation

@S2Ler S2Ler requested a review from 1ec5 November 4, 2021 06:49
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • Renamed the Locale.usesMetric property to Locale.usesMetricDistanceUnits. (#3547)

Comment thread Sources/MapboxCoreNavigation/Locale.swift Outdated
@1ec5 1ec5 added op-ex Refactoring, Tech Debt or any other operational excellence work. topic: localization labels Nov 11, 2021
@1ec5 1ec5 modified the milestones: v2.1, v2.1-rc Nov 11, 2021
@S2Ler S2Ler force-pushed the feature/deprecate-uses-metric branch from 7156c2c to dd30d69 Compare November 11, 2021 10:06
@S2Ler
Copy link
Copy Markdown
Contributor Author

S2Ler commented Nov 11, 2021

Suggested changelog entry:

  • Renamed the Locale.usesMetric property to Locale.usesMetricDistanceUnits. (#3547)

Added, also, mentioning that the old method is still there.

@S2Ler S2Ler force-pushed the feature/deprecate-uses-metric branch 2 times, most recently from 2c56e80 to 42da745 Compare November 11, 2021 10:20
@mapbox-github-ci-issues-5
Copy link
Copy Markdown

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-5
Copy link
Copy Markdown

Breaking Changes in MapboxNavigation

Breaking API Changes

InstructionsCardCell

  • removed var: container in InstructionsCardCell
  • removed method: layoutSubviews() in InstructionsCardCell

@S2Ler S2Ler force-pushed the feature/deprecate-uses-metric branch from 42da745 to c3efeac Compare November 11, 2021 12:03
@mapbox-github-ci-issues-3
Copy link
Copy Markdown

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-3
Copy link
Copy Markdown

No breaking changes detected in MapboxNavigation

@S2Ler S2Ler merged commit aa29d86 into main Nov 11, 2021
@S2Ler S2Ler deleted the feature/deprecate-uses-metric branch November 11, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

op-ex Refactoring, Tech Debt or any other operational excellence work. topic: localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants