Skip to content

Add rich instruction creation and AWS Polly [WIP]#42

Closed
bsudekum wants to merge 3 commits into
masterfrom
polly
Closed

Add rich instruction creation and AWS Polly [WIP]#42
bsudekum wants to merge 3 commits into
masterfrom
polly

Conversation

@bsudekum
Copy link
Copy Markdown
Contributor

@bsudekum bsudekum commented Feb 3, 2017

todo:

  • Add osrm-text-instruction translation files
  • properly import AWS
  • Only make public what needs to be public
  • Add test

/cc @frederoni @1ec5

@bsudekum
Copy link
Copy Markdown
Contributor Author

bsudekum commented Feb 3, 2017

cc @freenerd

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSRMTextInstructions and related resources should live in the Project-OSRM/osrm-text-instructions repository or a separate repository (if Carthage support is needed), not here. Additionally, the commit history for these files is important and should be preserved.

@1ec5 1ec5 mentioned this pull request Feb 17, 2017
5 tasks
@bsudekum
Copy link
Copy Markdown
Contributor Author

Going to reroll this into a new pr

@bsudekum bsudekum closed this Feb 27, 2017
@bsudekum bsudekum deleted the polly branch February 27, 2017 19:59
wishtrip-dev pushed a commit to wishtrip-dev/mapbox-navigation-ios that referenced this pull request Feb 28, 2018
@1ec5 1ec5 mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants