Additional camera zoom/tilt methods#583
Merged
Merged
Conversation
added 8 commits
July 11, 2018 19:05
…nt does not persist anymore
LukasPaczos
added
the
location-layer-plugin
LukasPaczos
force-pushed
the
544-additional-camera-methods
branch
from
b912b82 to
ee4afaa
Compare
danesfeder
approved these changes
Jul 17, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
@LukasPaczos this refactor is 💯 awesome work - I don't have much feedback other than the comment on the TODO
| this.previousAccuracyRadius = targetAccuracyRadius; | ||
| } | ||
|
|
||
| // TODO: 12/07/2018 canceling zoom and tilt |
Contributor
There was a problem hiding this comment.
This is okay to go into master as is?
Contributor
Author
There was a problem hiding this comment.
Whoops, definitely not. Good catch.
…abled on test devices
LukasPaczos
force-pushed
the
544-additional-camera-methods
branch
from
ee4afaa to
a6b0f3f
Compare
Contributor
Author
|
We also need to update the /cc @langsmith |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #544.
While working on #577 I noticed that it's hard to extend the
LocationLayerAnimatorwith new animation types, therefore, I refactored the code and updated the naming schema. Other than that, in this PR:CameraMode#NONE.I'm open for discussion whether the approach taken with the methods that work only if the camera mode is engaged should be the way to go. The example of the required implementation can be found in the test app changes.