Refactor tests / port to tape - #301
Merged
Merged
Conversation
Contributor
|
Unless you're planning on running tests in the browser (which node-pre-gyp probably isn't going to do), node-tap might be a better fit. Then you get the runner, reporter, coverage, and test framework all in one. |
|
Any status update? |
added 17 commits
September 7, 2017 12:49
…not contain exact version
springmeyer
force-pushed
the
tape-tests
branch
from
September 7, 2017 19:49
f2eb911 to
b189695
Compare
Contributor
Author
|
Going to stick with tape for the moment. I'm short on time and it was not immediately obvious to me how to port node-pre-gyp/test/build.test.js Lines 37 to 44 in 07704da |
This was referenced Dec 20, 2017
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Refactor tests / port to tape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging #300 I suspected that the mocha tests might be behaving unpredictably. I wondered if porting to tape would resolve the issues in #300. They did not, but moving to
tapeseems ideal anyway (given https://macwright.org/2014/03/11/tape-is-cool.html). so I forged ahead on these.Also solved in this PR along the way:
After the nodejs series started releasing 2.x and above we've seen the ABI only get bumped with new major versions, predictably.we now assume the ABI even when the exact minor.patch version is not stored in the abi crosswalk. This will avoid it needing to be updated as frequently (only for new major versions).