Skip to content

Refactor tests / port to tape - #301

Merged
springmeyer merged 18 commits into
masterfrom
tape-tests
Sep 7, 2017
Merged

Refactor tests / port to tape#301
springmeyer merged 18 commits into
masterfrom
tape-tests

Conversation

@springmeyer

@springmeyer springmeyer commented Jun 11, 2017

Copy link
Copy Markdown
Contributor

While debugging #300 I suspected that the mocha tests might be behaving unpredictably. I wondered if porting to tape would resolve the issues in #300. They did not, but moving to tape seems ideal anyway (given https://macwright.org/2014/03/11/tape-is-cool.html). so I forged ahead on these.

Also solved in this PR along the way:

@isaacs

isaacs commented Jun 11, 2017

Copy link
Copy Markdown
Contributor

Unless you're planning on running tests in the browser (which node-pre-gyp probably isn't going to do), node-tap might be a better fit. Then you get the runner, reporter, coverage, and test framework all in one.

@ajmas

ajmas commented Aug 25, 2017

Copy link
Copy Markdown

Any status update?

@springmeyer

Copy link
Copy Markdown
Contributor Author

Going to stick with tape for the moment. I'm short on time and it was not immediately obvious to me how to port

test.Test.prototype.stringContains = function(actual, contents, message) {
this._assert(actual.indexOf(contents) > -1, {
message: message || 'should contain '+contents,
operator: 'stringContains',
actual: actual,
expected: contents
});
};
over.

@springmeyer
springmeyer merged commit 9be0bde into master Sep 7, 2017
@springmeyer
springmeyer deleted the tape-tests branch September 7, 2017 20:02
hyj1991 pushed a commit to X-Profiler/node-pre-gyp that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants