Keep compatibility with node v0.10.x - #319
Merged
Merged
Conversation
springmeyer
force-pushed
the
node-v0.10
branch
from
September 22, 2017 12:32
f52b737 to
4d78348
Compare
This was referenced Sep 22, 2017
Contributor
Author
@aikar see above. However now v0.7.0 of node-pre-gyp has dropped node v0.10.x support, so now we're back on more recent request. |
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Keep compatibility with node v0.10.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My plan is to keep compatibility with node v0.10.x in the 0.x series and bump to v1.x (dropping node v0.10.x support) after the merge of #299
This is needed due to request/request#2772