Skip to content

run.util.js: Test building with msvs 2022 and get AppVeyor to pass#709

Closed
cclauss wants to merge 1 commit intomapbox:masterfrom
cclauss:patch-1
Closed

run.util.js: Test building with msvs 2022 and get AppVeyor to pass#709
cclauss wants to merge 1 commit intomapbox:masterfrom
cclauss:patch-1

Conversation

@cclauss
Copy link
Copy Markdown
Collaborator

@cclauss cclauss commented Apr 11, 2024

To support newer versions of Node.js > v17

npm ci
npm run update-crosswalk

test/run.util.js

  if (process.platform === 'win32') {
-    final_cmd += ' --msvs_version=2015 ';
+    final_cmd += ' --msvs_version=2022 ';
  }

appveyor.yml

+ matrix:  # TODO: Fix the `configures with unparsed options` tests and remove this allow_failures matrix.
+   allow_failures:
+     - nodejs_version: 20
+     - nodejs_version: 21

AppVeyor test results: https://ci.appveyor.com/project/Mapbox/node-pre-gyp/history

@yhahn, @mapsam, @axrj, @rafaykh90, @ewanharris, @ronilan, @acalcutt Your reviews, please.

@cclauss cclauss changed the title run.util.js: Test building with msvs 2022 run.util.js: Test building with msvs 2022 and get AppVeyor to pass Apr 11, 2024
@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 90650cb to bb14fbe Compare June 28, 2024 23:55
@cclauss cclauss mentioned this pull request Jun 29, 2024
@benmccann
Copy link
Copy Markdown
Collaborator

Thanks for picking up this repo!

Please add the modifications from #709 so we can see if the tests pass on modern versions of Node.js.

I'm afraid I'm a little confused. Appveyor appears to be failing on that PR. Also, why don't we just merge it to master in if it does fix the build and then rebase the PRs against master?

@cclauss
Copy link
Copy Markdown
Collaborator Author

cclauss commented Jun 29, 2024

I rebased to get rid of the git conflicts.

@cclauss cclauss closed this Jun 29, 2024
@cclauss cclauss deleted the patch-1 branch June 29, 2024 01:27
@cclauss
Copy link
Copy Markdown
Collaborator Author

cclauss commented Jun 29, 2024

Done in other pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants