Avoid npm warnings by supporting MODULE_BINARY_MIRROR env variable#953
Open
yunnysunny wants to merge 1 commit intomapbox:masterfrom
Open
Avoid npm warnings by supporting MODULE_BINARY_MIRROR env variable#953yunnysunny wants to merge 1 commit intomapbox:masterfrom
yunnysunny wants to merge 1 commit intomapbox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With newer versions of npm (v10+), using environment variables in the form of:
will trigger warnings such as:
This happens because npm now validates environment variables prefixed with npm_config_* against its known configuration keys, and custom keys used by tools like node-pre-gyp are no longer recognized.
Changes
To address this issue, this PR introduces support for an alternative environment variable:
Specifically:
The code now checks for
npm_config_<module>_binary_host_mirrorFalls back to
process.env.<MODULE>_BINARY_MIRROR