Disable location layer when place picker is paused or finished #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
My location layer should be disabled when the
PlacePickerActivityis no longer visible on the screen (i.e. paused or finished).This resolves two issues:
When the place picker activity was finished location services would not be properly shutdown and the app would leak a service connection to the Lost fused location service (Place picker activity leaks Lost service connection after place is selected #301).
This prevents location services from running hot when the place picker activity is in the background. Location updates are only needed when the place picker is visible on the screen and the user is in the process of selecting a place.
Proposed Changes
PlacePickerActivity#onPause().PlacePickerActivity#onResume().Fixes #301