Skip to content

Fixed bugs caused by what I suspect changed XCode behaviour. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petaren wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bugs caused by what I suspect changed XCode behaviour. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildTimeLogger/DerivedDataManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class DerivedDataManager {
let fileManager = FileManager.default

return folders.flatMap{ (url) -> File? in
if url.lastPathComponent != "ModuleCache",
if !url.lastPathComponent.contains("ModuleCache"),
let properties = try? fileManager.attributesOfItem(atPath: url.path),
let modificationDate = properties[FileAttributeKey.modificationDate] as? Date {
return File(date: modificationDate, url: url)
Expand Down
14 changes: 7 additions & 7 deletions BuildTimeLogger/XcodeDatabase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ struct XcodeDatabase {
let value = data[key] as? [String : AnyObject],
let schemeName = value["schemeIdentifier-schemeName"] as? String,
let title = value["title"] as? String,
let timeStartedRecording = value["timeStartedRecording"] as? Int,
let timeStoppedRecording = value["timeStoppedRecording"] as? Int,
let timeStartedRecording = value["timeStartedRecording"] as? Double,
let timeStoppedRecording = value["timeStoppedRecording"] as? Double,
let fileAttributes = try? FileManager.default.attributesOfItem(atPath: path),
let modificationDate = fileAttributes[FileAttributeKey.modificationDate] as? Date
else { return nil }
Expand All @@ -74,8 +74,8 @@ struct XcodeDatabase {
self.key = key
self.schemeName = schemeName
self.title = title
self.timeStartedRecording = timeStartedRecording
self.timeStoppedRecording = timeStoppedRecording
self.timeStartedRecording = Int(timeStartedRecording)
self.timeStoppedRecording = Int(timeStoppedRecording)
}

func processLog() -> String? {
Expand All @@ -86,11 +86,11 @@ struct XcodeDatabase {
return nil
}

static private func sortKeys(usingData data: [String: AnyObject]) -> [(Int, key: String)] {
var sortedKeys: [(Int, key: String)] = []
static private func sortKeys(usingData data: [String: AnyObject]) -> [(Double, key: String)] {
var sortedKeys: [(Double, key: String)] = []
for key in data.keys {
if let value = data[key] as? [String: AnyObject],
let timeStoppedRecording = value["timeStoppedRecording"] as? Int {
let timeStoppedRecording = value["timeStoppedRecording"] as? Double {
sortedKeys.append((timeStoppedRecording, key))
}
}
Expand Down