Skip to content

enable prettier by default#351

Merged
msand merged 2 commits into
masterfrom
@vonovak/actually-use-prettier
Apr 9, 2020
Merged

enable prettier by default#351
msand merged 2 commits into
masterfrom
@vonovak/actually-use-prettier

Conversation

@vonovak

@vonovak vonovak commented Feb 2, 2020

Copy link
Copy Markdown
Contributor

Summary

I removed "requirePragma": true from prettierrc because that option means prettier is not enabled unless explicitly turned on using the @format pragma (as it was in example/index.js).

After that I just ran eslint --fix and the code now follows the specified config.

Test Plan

  • eslint passes (it does locally :) )

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@msand

msand commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Mind rebasing on master?

@vonovak vonovak force-pushed the @vonovak/actually-use-prettier branch from bf49cb6 to c228a97 Compare April 9, 2020 08:33
@vonovak

vonovak commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

@msand done; also rmeoved "git add" from lint-staged because I was getting

⚠ Some of your tasks use git add command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

@msand msand merged commit 47521c1 into master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants