fix: fix recent incompatibility when using reanimated#194
Merged
Conversation
mrousavy
approved these changes
May 11, 2024
Member
mrousavy
left a comment
There was a problem hiding this comment.
lgtm.
we should probably also use the source maps somehow, no?
|
aking the liberty of asking, roughly when will this be updated Submitted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often times this library is used next to reanimated.
In this case the worklets are transpiled by the reanimated babel plugin.
The reanimated babel plugin uses
initData.sourceMapinstead of RNWC currentinitData.__sourceMap.This has gone unnoticed so far, cause we never checked for that property.
In this PR, which was recently merged
IWorklet/IWorkletize<>) #188a check was introduced, that checks if the provided function is a
worklet:react-native-worklets-core/src/hooks/useWorklet.ts
Lines 6 to 9 in c495c52
In this function we check for the
__sourceMapidentifier, which won't be present when we run with reanimated.The solution to this seems to be to use the same identifier name as in reanimated.
Without this change we will see this error with a stack where everything is a valid worklet:
Fixes: #190