Skip to content

fix: fix recent incompatibility when using reanimated #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrousavy merged 1 commit into from
May 11, 2024
Merged

fix: fix recent incompatibility when using reanimated #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/WKTJsiWorklet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ static const char *PropNameWorkletInitDataCode = "code";
static const char *PropNameJsThis = "jsThis";

static const char *PropNameWorkletInitDataLocation = "location";
static const char *PropNameWorkletInitDataSourceMap = "__sourceMap";
static const char *PropNameWorkletInitDataSourceMap = "sourceMap";

static const char *PropNameWorkletLocation = "__location";
static const char *PropNameWorkletAsString = "asString";
Expand Down
6 changes: 3 additions & 3 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ PODS:
- React-jsinspector (0.71.2)
- React-logger (0.71.2):
- glog
- react-native-worklets-core (1.3.0):
- react-native-worklets-core (1.3.2):
- React
- React-callinvoker
- React-Core
Expand Down Expand Up @@ -495,7 +495,7 @@ SPEC CHECKSUMS:
React-jsiexecutor: c7e028406112db456ac3cf5720d266bc7bc20938
React-jsinspector: ea8101acf525ec08b2d87ddf0637d45f8e3b4148
React-logger: 97987f46779d8dd24656474ad0c43a5b459f31d6
react-native-worklets-core: 7a50c0c14005cc57df8583eabd99ea3f467fa277
react-native-worklets-core: ff4a4076ad86469e61ec8e39da2cb13c55da2385
React-perflogger: c7ccda3d1d1da837f7ff4e54e816022a6803ee87
React-RCTActionSheet: 01c125aebbad462a24228f68c584c7a921d6c28e
React-RCTAnimation: 5277a9440acffc4a5b7baa6ae3880fe467277ae6
Expand All @@ -513,4 +513,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: fd46804085f978bcef56543628998164c7956884

COCOAPODS: 1.14.3
COCOAPODS: 1.12.1
2 changes: 1 addition & 1 deletion src/plugin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ function makeWorklet(t, fun, state) {
if (sourceMapString) {
initDataObjectExpression.properties.push(
t.objectProperty(
t.identifier("__sourceMap"),
t.identifier("sourceMap"),
t.stringLiteral(sourceMapString)
)
);
Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export type IWorklet<TFunc extends Function> = TFunc & {
/**
* Contains a source-code map of the Worklet to properly resolve stacktraces.
*/
__sourceMap: string;
sourceMap: string;
};
/**
* Holds a unique compile-time hash for the code and closure of this Worklet.
Expand Down
2 changes: 1 addition & 1 deletion src/worklet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function isWorklet<TFunc extends Function>(
if (initData == null || typeof initData !== "object") return false;

if (
typeof initData.__sourceMap !== "string" ||
typeof initData.sourceMap !== "string" ||
typeof initData.code !== "string" ||
typeof initData.location !== "string"
)
Expand Down