Add worklet() func that throws if value is not a worklet#187
Merged
Conversation
Member
Author
|
@chrfalch some questions;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
worklet(...)andisWorklet(..)functions:worklet(...)This will do some runtime checking to ensure the given function is a worklet (uses
__initData,__closureand__workletHash) and throws with some useful debugging information if it isn't.I will use this in VisionCamera's
useFrameProcessorfunction to make sure people pass in worklets (funcs with'worklet'directive) and they installed the babel plugin properly. Otherwise the error is a bit cryptic, with this it's more clear what went wrong:Also, the returned type is useful because you can now safely access
func.__workletHashorfunc.__closure.isWorklet(...)Same thing as
worklet(...), but only returns false if the function is not a worklet instead of throwing an error.Changes to
useWorklet(..)The
useWorklethook now usesworklet(..)underneath to ensure the user passed in a correct Worklet.Also, I now removed the
dependenciesparameter by automatically using the values infunc.__closurefor theuseMemo's dependencies. This is pretty cool because people often forgot to the hook dependencies inuseFrameProcessorand wondered why it didn't update/re-build after a re-render.