-
Notifications
You must be signed in to change notification settings - Fork 63
chore: proper new arch + backwards compat using install function #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
f8bf6d7
feat: Move everything into `package/`
mrousavy a39ab21
Update Podfile.lock
mrousavy efbf23e
Create .gitignore
mrousavy 23b06b3
Update .gitignore
mrousavy 5d7c8b7
feat: Upgrade Android to new arch C++ only
mrousavy 4f48e8f
Create C++ loader
mrousavy eed7c0f
fix: Fix configs
mrousavy 2fc4b4e
Update react-native.config.js
mrousavy c4d3d8a
Update package.json
mrousavy a37b3af
Update useRunOnJS.ts
mrousavy d2f184b
Update package.json
mrousavy 58d75aa
Rename
mrousavy 6854053
chore: release 2.0.0-beta.1
mrousavy 84fb2d2
Export Worklets
mrousavy 25c0c7f
fix: Update CI paths
mrousavy 09eb3bd
fix: Fix CI
mrousavy 651f4ac
Remove JSC for simplicity
mrousavy 0bfd8cc
feat: Upgrade Example app
mrousavy 1030273
feat: Create `NativeWorkletsModule` CXX
mrousavy a40ee2b
Format
mrousavy 15552fd
Try to refactor everything away from static singletons....
mrousavy cac72f3
oh my god
mrousavy a16079f
fix: Fix decorators again
mrousavy 6201411
fix: Fix ctx throwing
mrousavy f03a4d7
Update WKTJsiWorkletContext.h
mrousavy 224887f
Update WKTJsiWorklet.h
mrousavy f042e4f
feat: Try to clean up createRunInContext
mrousavy ada3a53
feat: Rewrite the whole `createCallInContext` logic into `FunctionInv…
mrousavy 30e3d79
fix: Implement createRunOnJS - stub out Promise
mrousavy 6eebe9c
feat: Create `FunctionInvoker:: callAndForget`
mrousavy e179d2f
fix: Try to use simple Promise approach... fails
mrousavy 6f022fc
Revert "fix: Try to use simple Promise approach... fails"
mrousavy 6d224ee
Update types.ts
mrousavy f619ec4
Add Invoker again
mrousavy cb236d1
revert: Revert all changes that tried to remove the singleton pattern
mrousavy e00ecdb
feat: Initialize default instance so everything works again ✅
mrousavy 6278404
fix: If a promise is resolved/rejected already, ensure we always have…
mrousavy 0c3e69d
Merge branch 'main' into feat/cxxturbomodule
mrousavy 25ce228
fix: Fix Android build
mrousavy e4cd40a
fix: Fix missing includes
mrousavy 2b2bf73
Clang Format
mrousavy cf64156
Lint
mrousavy bffe8a2
Update action.yml
mrousavy 26624fa
fix lint
mrousavy ed76d77
Update build-android.yml
mrousavy e4d75af
fix format
mrousavy ac52148
fix: Add the `react_codegen_RNWorkletsSpec` project with headers
mrousavy d8584b2
Revert "fix: Add the `react_codegen_RNWorkletsSpec` project with head…
mrousavy 17ac6c2
Update ModuleNotFoundError.ts
mrousavy 5b4c8c1
chore: release 2.0.0-beta.2
mrousavy b2fdab6
Update banner
mrousavy 91d285d
fix: Don't build CMake ourselves - the consumer app will build it
mrousavy b919021
Remove `HERMES_ENABLE_DEBUGGER` (`hermes_executor`)
mrousavy 9d7c207
fix: Update CI
mrousavy a046b9f
Update ModuleNotFoundError.ts
mrousavy 5faaa18
Update docs
mrousavy e8ae864
chore: release 2.0.0-beta.3
mrousavy 6a9807e
chore: pod install
hannojg f046ee8
chore: add json parse test (#204)
hannojg 9c9c009
fix: Include RN config in npm
mrousavy 0dd4971
chore: release 2.0.0-beta.4
mrousavy 6e85b4b
add sample CxxTurboModule (iOS only for now)
hannojg 88c5969
removed dev testing code
hannojg 552186a
add test for native context creation
hannojg 5cd8bf9
chore(example): fix typescript types
hannojg 1d74be9
fix: Enable stricter header search paths for import at build time (`D…
hannojg 2d3c8d6
upgrade example app to RN 0.75
hannojg 2e0437e
ios upgrade RN
hannojg 00dd8b9
wip android
hannojg 6d99031
fix android build errors
hannojg 98cc902
android call JNI code for installation
hannojg 5ae82cf
android: inject WorkletsProxy into global
hannojg 2ac4598
suppress error
hannojg b0c8500
improve error message
hannojg d9dd18f
fix(android): build errors old arch
hannojg e806bcd
iOS: new arch
hannojg 4bec65e
ios: old arch
hannojg 13579bc
pod install
hannojg b59d1e9
formatting
hannojg 8eaf6a3
it was the lord
hannojg 1fc5a19
restore previous cpp code from main
hannojg 0a1d69d
remove double reference
hannojg fe3b4fa
run cleanup
hannojg 5de68a9
chore(ci): fix eslint action
hannojg 94ee22d
update snapshots
hannojg f164f57
Revert "update snapshots"
hannojg 5f451f2
update snapshots
hannojg c697e21
clang format setup like vision camera
hannojg a04d562
format
hannojg 59bd3d5
android: handle different js engines correctly
hannojg 49c849d
update requirements
hannojg 714f460
chore: fix ci
hannojg c38a47e
chore: fix ci
hannojg 970cddf
chore: fix ci
hannojg 0db0faa
chore: fix ci
hannojg c9f4734
chore: fix ci
hannojg a169615
wip: delete file
hannojg 2cf5fa9
add file back
hannojg 43c7742
wip
hannojg 24dc5e3
wip: fix CI clang-format
hannojg 0502628
wip: test breaking format
hannojg f77be16
Revert "wip: test breaking format"
hannojg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Config for clang-format version 18 | ||
|
|
||
| # Standard | ||
| BasedOnStyle: llvm | ||
| Standard: c++14 | ||
|
|
||
| # Indentation | ||
| IndentWidth: 2 | ||
| ColumnLimit: 140 | ||
|
|
||
| # Includes | ||
| SortIncludes: CaseSensitive | ||
| SortUsingDeclarations: true | ||
|
|
||
| # Pointer and reference alignment | ||
| PointerAlignment: Left | ||
| ReferenceAlignment: Left | ||
| ReflowComments: true | ||
|
|
||
| # Line breaking options | ||
| BreakBeforeBraces: Attach | ||
| BreakConstructorInitializers: BeforeColon | ||
| AlwaysBreakTemplateDeclarations: true | ||
| AllowShortFunctionsOnASingleLine: Empty | ||
| IndentCaseLabels: true | ||
| NamespaceIndentation: Inner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Validate C++ | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - ".github/workflows/validate-cpp.yml" | ||
| - "package/cpp/**" | ||
| - "package/android/src/main/cpp/**" | ||
| - "package/ios/**" | ||
| pull_request: | ||
| paths: | ||
| - ".github/workflows/validate-cpp.yml" | ||
| - "package/cpp/**" | ||
| - "package/android/src/main/cpp/**" | ||
| - "package/ios/**" | ||
|
|
||
| jobs: | ||
| lint: | ||
| name: Check clang-format | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| path: | ||
| - "package/cpp" | ||
| - "package/android/src/main/cpp" | ||
| - "package/ios" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Run clang-format style check | ||
| uses: DoozyX/clang-format-lint-action@v0.18.2 | ||
| with: | ||
| source: ${{ matrix.path }} | ||
| clangFormatVersion: 18.1.8 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.