Implemented Advanced Configuration#8
Merged
Merged
Conversation
- Changed the internal Mapping type to std::unordered_map - Made static member function `isModified` a free function
Added most keys from US keyboard Added convenience renamings for common keys and for insanely named keys
Removed unnecessary pointer
Refactored key event creation
Modernized read/write architecture. Renamed writeCombo to write_keytap
Renamed SYN to SYNC. Removed unused function getState. Removed prefixed underscore from class members. Renamed member function matches to is_intercept.
Corrected logic error I introduced earlier.
Added Interceptor abstraction. Added preliminary Layers and Modifiers abstraction
Implemented advanced yaml configuration. Added Interceptor abstraction
Corrected wrong key name
Removed logs, unnecessary includes. Added helper functions. Renamed InterceptedKey to Intercept, InterceptedKeyLayer to Layer and InterceptedKeyModifier to Modifier. Removed old configuration artifacts.
Decouple uninstall from clean
Added global config file. Consolidated writing events. De-nested some logic. Added meta keys.
Reordered modifier and layer class to be in usage order
maricn
approved these changes
Mar 31, 2023
Owner
maricn
left a comment
maricn
left a comment
There was a problem hiding this comment.
sorry for the delay on the review here, i've dived into it and the code changes generally look great.. i especially like some simplifications of branching logic and reused code.. that being said i'm not able to test this in action atm, but from looking at the code it should be doing what it promises..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.