pass button classname instead of icon classname to fix padding #7006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
reviewed
Oct 30, 2025
| // as useState doesn't reinitialize on re-renders | ||
| useEffect(() => { | ||
| setLocalValue(props.value); | ||
| }, [props.value]); |
Contributor
There was a problem hiding this comment.
can we revert this or did this fix a bug? because last time we did a cleanup like this, it broke things unexpectedly
mscolnick
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
the copy button was taking up unecessary padding, because the styles were applied to the icon, not the button.
before:
after:
🔍 Description of Changes
📋 Checklist