fix: safe annotation quotes #7028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
previously approved these changes
Nov 1, 2025
akshayka
previously approved these changes
Nov 1, 2025
Contributor
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
LGTM. But does it make sense to add a unit test for the unparsable code path?
Collaborator
Author
|
@akshayka I added a failure case by mocking. There's still an unhappy path where |
Collaborator
Author
|
Think CI will be fixed by #7034 |
akshayka
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
fixed #7026
If annotations without top-level resolution were quoted and containing quotes themselves, syntax breaking serialization occurred rendering a notebook un-openable.
This fixes this particular issue and additionally adds a defense guard such that invalid code should never be serialized.