improvement: inline local images (virutal files) in the HTML export #7087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscolnick
commented
Nov 5, 2025
| buffer = virtual_file.buffer | ||
| # Skip adding if buffer is empty | ||
| if len(buffer) == 0: | ||
| return |
Contributor
Author
There was a problem hiding this comment.
previous bug that would log an unnecessary error
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
reviewed
Nov 6, 2025
| LOGGER = _loggers.marimo_logger() | ||
|
|
||
|
|
||
| class _HTMLAttributeReplacer(HTMLParser): |
Collaborator
There was a problem hiding this comment.
Surprised you had to roll your own here
dmadisetti
reviewed
Nov 6, 2025
| from nbformat.notebooknode import NotebookNode # type: ignore | ||
|
|
||
| VIRTUAL_FILE_ALLOWED_ATTRIBUTES = {"src"} | ||
| VIRTUAL_FILE_ALLOWED_TAGS = {"img"} |
Collaborator
There was a problem hiding this comment.
A previous version of this allowed video / audio tags as well. Is that not worth it too large? Might be worth putting a comment at least
Contributor
Author
There was a problem hiding this comment.
yea i didn't want to shove those in here. i can add a comment
dmadisetti
previously approved these changes
Nov 6, 2025
Collaborator
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
It would be nice if we could delegate some of the sanitization stuff- but this is an OK stop gap otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This traversed
<img srcelements and replaces virtual files./@file/foo.pngwith the file and data-uri, so these HTML files can be more self-contained