Skip to content

Conversation

@peterbygrave
Copy link
Contributor

📝 Summary

This PR ensures only a single "async" appears in rendered function signatures.
Previously it was being added by both _get_signature and it's caller in the inspect class.

🔍 Description of Changes

Before:
Screenshot 2025-11-05 at 22 22 31

After:
Screenshot 2025-11-05 at 22 22 08

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 5, 2025 10:25pm

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@peterbygrave
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mscolnick mscolnick merged commit 6ba411b into marimo-team:main Nov 6, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants