improve: do not trigger UI element warnings for state updates #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defined Right now the runtime eagerly updates states value when a state update is registered. This should be unnecessary (but maybe was needed for file watching element, which is when this code was introduced), and it hits a code path for UI elements that triggers a very loud error. Instead of fixing the underlying issue, this PR prevents the code path from being triggered and prints a gentler warning.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Nov 6, 2025
dmadisetti
reviewed
Nov 6, 2025
| cell_id = ctx.execution_context.cell_id | ||
| with self._state_lock: | ||
| self.state_updates[state] = cell_id | ||
| # TODO(akshayka): State should not be updated eagerly like this, |
Collaborator
There was a problem hiding this comment.
Context, this path is hit when you update state from the same cell:
because state does not have a bound name it cannot be looked up, which means that some of this logic in the function doesn't apply- so early exiting is correct.
PR #5143
Also provided an early exit (but this is better since we update state_updates)
There's also an embedded app path where I think state is associated with the parent cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the runtime eagerly updates states value when a state update
is registered. This should be unnecessary (but maybe was needed
for file watching element, which is when this code was introduced),
and it hits a code path for UI elements that triggers a very loud error.
Instead of fixing the underlying issue, this PR prevents the
code path from being triggered and prints a gentler warning.
Related: #7060