Skip to content

Conversation

@enosh
Copy link
Contributor

@enosh enosh commented Nov 12, 2025

📝 Summary

Adds a spinner to mo.ui.file_browser if listing files takes more than 200ms.

🔍 Description of Changes

I was using mo.ui.file_browser with S3, browsing a medium size directory and the initial load takes something like 20 seconds without any indication for what's happening. Felt a bit broken so this changes that.

The delay is there to avoid flashing the spinner when listing is quick.

Here's a demo with the change:

fb-spinner-demo.mov

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

I have read the CLA Document and I hereby sign the CLA.

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 12, 2025 11:28am

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@enosh
Copy link
Contributor Author

enosh commented Nov 12, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, great implementation!

@mscolnick mscolnick merged commit 64f7bfe into marimo-team:main Nov 12, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants