feat: mo.ui.file_browser show spinner when listing is slow #7155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds a spinner to
mo.ui.file_browserif listing files takes more than 200ms.🔍 Description of Changes
I was using
mo.ui.file_browserwith S3, browsing a medium size directory and the initial load takes something like 20 seconds without any indication for what's happening. Felt a bit broken so this changes that.The delay is there to avoid flashing the spinner when listing is quick.
Here's a demo with the change:
fb-spinner-demo.mov
📋 Checklist
I have read the CLA Document and I hereby sign the CLA.