fix: mermaid embedded in markdown #7205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscolnick
requested review from
Light2Dark,
akshayka and
manzt
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
reviewed
Nov 18, 2025
| attributeNameCheck: /^[A-Za-z][\w-]*$/, | ||
| }, | ||
| SAFE_FOR_XML: html.includes("marimo-mermaid"), | ||
| SAFE_FOR_XML: !html.includes("marimo-mermaid"), |
Contributor
There was a problem hiding this comment.
do you want to add a comment? I am confused that it's supposed to be ! includes.
Light2Dark
previously approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mermaid embedded in markdown. Bad boolean flipped.
This also fixes the markdown formatting of
examples/misc/bayes_theorem.py