fix: handle out-of-bounds tool call index in AI streaming (#7330) #7356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes an `IndexError: list index out of range` that occurred when using OpenAI-compatible providers (like DeepSeek) with the "Generate with AI" feature.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an IndexError that occurred when using OpenAI-compatible providers (like DeepSeek) with AI streaming features. The issue arose when providers sent tool call delta chunks before the tool call start chunk, causing an out-of-bounds access to the tool_call_ids list.
- Adds bounds checking before accessing
tool_call_idsarray - Adds comprehensive test coverage for the edge case
- Follows existing pattern used in GoogleProvider
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| marimo/_server/ai/providers.py | Added bounds check tool_index < len(tool_call_ids) in OpenAIProvider and BedrockProvider to prevent IndexError when tool deltas arrive before tool call initialization |
| tests/_server/ai/test_providers.py | Added regression tests for both OpenAIProvider and BedrockProvider to verify graceful handling of out-of-bounds tool call indices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Light2Dark
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7330
Summary
Fixes an
IndexError: list index out of rangethat occurred when using OpenAI-compatible providers (like DeepSeek) with the "Generate with AI" feature.