Add ImageContentPolyglotValidator to prevent polyglot file uploads#10
Open
asannikov wants to merge 1 commit intomarkshust:mainfrom
Open
Add ImageContentPolyglotValidator to prevent polyglot file uploads#10asannikov wants to merge 1 commit intomarkshust:mainfrom
asannikov wants to merge 1 commit intomarkshust:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new plugin, ImageContentPolyglotValidator, to enhance the security of image uploads by scanning the actual content of base64-encoded data for malicious PHP markers and polyglot signatures.
Problem
Existing checks primarily focus on file extensions, which can be bypassed by "polyglot" files—files that are valid images (e.g., starting with a GIF header) but also contain executable PHP code (e.g., GIF89a;<?php ...).
Solution
The new ImageContentPolyglotValidator plugin:
Key Changes