feat(polyshell-patch): harden ImageProcessor validation with GD re-encode and caps#13
Open
speedupmate wants to merge 1 commit intomarkshust:mainfrom
Open
feat(polyshell-patch): harden ImageProcessor validation with GD re-encode and caps#13speedupmate wants to merge 1 commit intomarkshust:mainfrom
speedupmate wants to merge 1 commit intomarkshust:mainfrom
Conversation
…e and caps Add StrictImagePayloadValidator plus an around plugin on ImageProcessor::processImageContent to verify magic bytes, align parser MIME with the declared type, enforce a 5 MiB decoded ceiling and Base64 length bound, cap dimensions before GD work, and require ext-gd to re-encode JPEG/PNG/GIF so non-image data is dropped. Keep extension allowlists on the validator and uploader; throw LocalizedException with __() for user-facing errors. Composer now requires ext-gd; PHPCS-clean with targeted DiscouragedFunction ignores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add StrictImagePayloadValidator plus an around plugin on ImageProcessor::processImageContent to verify magic bytes, align parser MIME with the declared type, enforce a 5 MiB decoded ceiling and Base64 length bound, cap dimensions before GD work, and require ext-gd to re-encode JPEG/PNG/GIF so non-image data is dropped. Keep extension allowlists on the validator and uploader; throw LocalizedException with __() for user-facing errors. Composer now requires ext-gd; PHPCS-clean with targeted DiscouragedFunction ignores.