Skip to content

Update PersistentRotation for KSP 1.12.5#46

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
markusa380:Developmentfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5
Closed

Update PersistentRotation for KSP 1.12.5#46
Sean-Kenneth-Doherty wants to merge 1 commit into
markusa380:Developmentfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • add the missing UnityEngine.AnimationModule project reference needed to build against KSP 1.12.5
  • bump the AVC metadata to 1.8.8 and KSP 1.12.5 / max 1.12.99
  • align the assembly version and tracked plugin DLL with the 1.8.8 build

Validation

  • Checked repository contribution surface: no CONTRIBUTING, CODE_OF_CONDUCT, PR template, or .github workflow docs were present.
  • Checked open PRs first: fixes, need to check #41 and Linuxgurugamer branch #42 are older linuxgurugamer branches with larger toolbar/localization/project changes. This PR is intentionally narrow and does not try to replace that work.
  • python -m json.tool GameData/PersistentRotation/PersistentRotation.version
  • xbuild /p:Configuration=Release /p:ReferencePath="/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/KSP_Data/Managed" PersistentRotation.sln
    • Before adding UnityEngine.AnimationModule, the KSP 1.12.5 build failed on Animator being defined in an unreferenced assembly.
    • After the project reference update, the build succeeded with 0 warnings and 0 errors.
  • monodis --assembly GameData/PersistentRotation/Plugins/PersistentRotation.dll
    • Generated assembly version reports 1.8.8.0.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] Update PersistentRotation for KSP 1.12.5 Update PersistentRotation for KSP 1.12.5 May 17, 2026
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5 branch May 18, 2026 01:59
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty restored the codex/ksp-1.12.5 branch May 18, 2026 02:03
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Closing this under the stricter review bar: this is mostly KSP 1.12.5 metadata/build-reference maintenance without a concrete user-facing issue, maintainer release request, or runtime proof. I do not want to spend maintainer review time on it as-is.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5 branch May 18, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant