Conversation
djhi
commented
Jan 9, 2025
djhi
commented
Jan 9, 2025
| export const LocalesMenuButtonClasses = {}; | ||
|
|
||
| const Root = styled(Box, { | ||
| const Root = styled('div', { |
Contributor
Author
There was a problem hiding this comment.
djhi
commented
Jan 9, 2025
slax57
requested changes
Jan 10, 2025
Comment on lines
+146
to
+147
| <ListItem disablePadding> | ||
| <ListItemButton |
Contributor
There was a problem hiding this comment.
Any changes in the CRM should be backported to https://github.com/marmelab/atomic-crm.
Besides, why do you need those changes? To my understanding, the MUI version used by the CRM demo shouldn't have changed, right?
UPDATE: I take it you kept those changes to prepare the compatibility with MUI v6, so I'm OK to keep them. But still, you'll need to open a PR to backport them to marmelab/atomic-crm.
Contributor
Author
There was a problem hiding this comment.
Those changes work in v5 too. We were using deprecated features that have been removed in v6. I'd rather address them now than forget them
slax57
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MUI v6 is out.
Solution
How To Test
Works with MUIv5
npm init react-admin react-admin-v6npm add @mui/material@^5.16.12 @mui/icons-material@^5.16.12react-admin-v6/node_modulesdirectoryWorks with MUIv6
^6.0.0npm installAdditional Checks
masterfor a bugfix, ornextfor a feature