Skip to content

[Doc] Remove emptyText prop from <AutoCompleteArrayInput> doc as it is not supported - #9073

Merged
slax57 merged 3 commits into
marmelab:masterfrom
gitstart:RA-OSS-10
Jul 17, 2023
Merged

[Doc] Remove emptyText prop from <AutoCompleteArrayInput> doc as it is not supported#9073
slax57 merged 3 commits into
marmelab:masterfrom
gitstart:RA-OSS-10

Conversation

@gitstart

@gitstart gitstart commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Here is the GitStart Ticket for this pull request: RA-OSS-10

  • Please mark your PR as "ready for review" when you have completed all requirements.
  • Please ensure that your PR is reviewed by at least 2 people after you have completed it.
  • Comments for review or requested changes from the upstream client will be notified to you by email and will also show on the ticket page.
  • After the PR is merged on the upstream, please merge this PR.
  • If there exist merge conflicts on your current PR and you have to close the PR instead of merging it, please go to the ticket page to manually finish the task that is related to this PR.

https://www.loom.com/share/3ba845e8ded54d34a24b23b30528d782?sid=300cb3dc-7dd8-4306-9418-e3bba8ba79ac

Happy hacking! 🎉

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @passy4ucj gitstart_bot
pushing RA-OSS-10 to client
82bd539 
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart
gitstart marked this pull request as ready for review July 5, 2023 05:51
slax57
slax57 requested changes Jul 5, 2023
View reviewed changes

@slax57 slax57 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice catch, thanks!

However, I disagree with the fix.

Currently this adds the emptyText to the list of choices, but it becomes selectable (which is not suitable) and besides it still does not appear automatically when the input is empty.

IMO we should rather change the docs to say that AutocompleteArrayInput simply does not support this prop.

@djhi @fzaninotto do you confirm?

gitstart and others added 2 commits July 13, 2023 10:14
@gitstart
Merge commit '205e5aeeb1e136be5863e038de8da0d39446160a' into RA-OSS-10
05997a0
@gitstart @passy4ucj gitstart_bot
revert change - change docs
daa933a 
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart

gitstart commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

This is a nice catch, thanks!

However, I disagree with the fix.

Currently this adds the emptyText to the list of choices, but it becomes selectable (which is not suitable) and besides it still does not appear automatically when the input is empty.

IMO we should rather change the docs to say that AutocompleteArrayInput simply does not support this prop.

@djhi @fzaninotto do you confirm?

Ok the emptyText props have been removed from the AutocompleteArrayInput docs

@gitstart
gitstart requested a review from slax57 July 13, 2023 10:16
slax57
slax57 approved these changes Jul 17, 2023
View reviewed changes

@slax57 slax57 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added this to the 4.12.2 milestone Jul 17, 2023
@slax57
slax57 merged commit 0db0e81 into marmelab:master Jul 17, 2023
@slax57 slax57 changed the title RA-OSS-10 - The documentation says that <AutoCompleteArrayInput> supports the emptyText property, but it does not work. [Doc] Remove emptyText prop from <AutoCompleteArrayInput> doc as it is not supported Jul 17, 2023
@erwanMarmelab erwanMarmelab mentioned this pull request Jul 29, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slax57 slax57 slax57 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.12.2

Development

Successfully merging this pull request may close these issues.

2 participants

@gitstart @slax57