Rename isCollapsed to isExpanded#54
Merged
marouanekadiri merged 1 commit intomarouanekadiri:masterfrom Feb 20, 2021
Merged
Conversation
marouanekadiri
approved these changes
Feb 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this library, I found myself confused because setting
isCollapsedto true was resulting in the component displaying the body rather than hiding it. I then read the documentation more carefully, and the README in fact says next toisCollapsed: "show the CollapseBody if true" . So it was working as intended, but not working as my intuition would lead me to believe, since the word "collapse" means to hide, or compress.So this PR suggests a name change from
isCollapsedtoisExpanded, to better describe the intended functionality of the prop.All tests passing: