Add token-based authentication.#20
Open
jbuchbinder wants to merge 2 commits intomartini-contrib:masterfrom
Open
Add token-based authentication.#20jbuchbinder wants to merge 2 commits intomartini-contrib:masterfrom
jbuchbinder wants to merge 2 commits intomartini-contrib:masterfrom
Conversation
token.go
Outdated
Contributor
There was a problem hiding this comment.
Why would you use the X-Token header? Token-based authentication usually uses the Authorization header as well, together with the Bearer keyword instead of Basic (or sometimes no keyword at all).
Examples:
Authorization: mytoken
Authorization: Bearer mytoken
Author
There was a problem hiding this comment.
A bunch of third party APIs have done so to avoid any confusion with Basic auth -- but I'm fine with using Authorization: Bearer instead. Do you want an adjusted patch set?
Contributor
There was a problem hiding this comment.
Nah, I don't really care that much. Either way is fine with me.
If @codegangsta if fine with this patch, I'd just add a few simple tests before we merge, that's all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds authentication based on a passed token, contained in the
X-Tokenheader. It allows a login endpoint to create a token which can be passed as a header to all subsequent API calls.