Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
e16f4d2
add viewModels
marty-suzuki Jan 23, 2018
82f3e80
add Actions, Dispatcher, Stores
marty-suzuki Jan 23, 2018
c45ad67
fix syntax
marty-suzuki Feb 17, 2018
52705ee
Merge branch 'mvp' into mvvm
marty-suzuki Mar 1, 2019
e6e2ba9
fix conflict
marty-suzuki Mar 2, 2019
ec7f9e2
Merge branch 'mvp' into mvvm
marty-suzuki Mar 2, 2019
1149765
fix project
marty-suzuki Mar 2, 2019
a54c3d6
fix FavoriteModel
marty-suzuki Mar 3, 2019
42af1c9
fix SearchModel
marty-suzuki Mar 3, 2019
0dfe9fe
fix RepositoryModel
marty-suzuki Mar 3, 2019
65ac8f4
fix diff
marty-suzuki Mar 3, 2019
92a8c4d
Merge branch 'mvvm' into flux
marty-suzuki Mar 3, 2019
614e65c
fix conflict
marty-suzuki Mar 4, 2019
0882440
add Flux
marty-suzuki Mar 4, 2019
e2bd594
Merge branch 'mvp' into mvvm
marty-suzuki Mar 4, 2019
8734125
Merge branch 'mvvm' into flux
marty-suzuki Mar 4, 2019
afd129a
fix diff
marty-suzuki Mar 4, 2019
4aaf7e5
remove extra files
marty-suzuki Mar 4, 2019
f437c3c
Merge branch 'mvp' into mvvm
marty-suzuki Feb 12, 2021
e271174
Fix ApiSession
marty-suzuki Feb 12, 2021
82f4104
Fix FavoriteModel
marty-suzuki Feb 12, 2021
fc26e10
Fix RepositoryModel
marty-suzuki Feb 12, 2021
ee8508a
Fix SearchModel
marty-suzuki Feb 12, 2021
4b28c0d
Fix Favorite
marty-suzuki Feb 12, 2021
74b9128
Fix Repository
marty-suzuki Feb 12, 2021
6e17dd2
Fix UserRepository
marty-suzuki Feb 12, 2021
acc7832
Fix Search
marty-suzuki Feb 12, 2021
51087f4
Fix injection
marty-suzuki Feb 12, 2021
4cc53eb
Fix xcodeproj
marty-suzuki Feb 12, 2021
d0dbf62
Merge branch 'mvp' into mvvm
marty-suzuki Feb 12, 2021
ad63067
Fix images
marty-suzuki Feb 12, 2021
0016cc6
Merge branch 'mvp' into mvvm
marty-suzuki Feb 12, 2021
151c60e
Merge branch 'mvvm' into flux
marty-suzuki Feb 13, 2021
c99bf0c
Remove common flux
marty-suzuki Feb 14, 2021
9ee9f50
Add favorite flux
marty-suzuki Feb 14, 2021
1aea403
Add repository flux
marty-suzuki Feb 14, 2021
e6576ef
Add user repository flux
marty-suzuki Feb 14, 2021
ecbd20e
Add search flux
marty-suzuki Feb 14, 2021
4809ec9
Fix injection
marty-suzuki Feb 14, 2021
2eea7d7
Fix xcodeproj
marty-suzuki Feb 14, 2021
422e543
Fix injection
marty-suzuki Feb 14, 2021
43bb448
Merge branch 'mvvm' into flux
marty-suzuki Feb 14, 2021
b061a08
Fix xcodeproject
marty-suzuki Feb 14, 2021
588e4c6
Fix AppDelegate
marty-suzuki Feb 14, 2021
bb4ab4a
Update README
marty-suzuki Feb 14, 2021
46318b8
Fix images
marty-suzuki Feb 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix diff
  • Loading branch information
marty-suzuki committed Mar 3, 2019
commit 65ac8f489976d2186dd13cbff17fad045716142e
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import RxSwift
import RxCocoa

final class FavoriteViewController: UIViewController {
@IBOutlet weak var tableView: UITableView!
@IBOutlet private(set) weak var tableView: UITableView!

private let dataSource: FavoriteViewDataSource
private let viewModel: FavoriteViewModel
let viewModel: FavoriteViewModel
let dataSource: FavoriteViewDataSource

private let disposeBag = DisposeBag()

Expand All @@ -38,7 +38,6 @@ final class FavoriteViewController: UIViewController {

dataSource.configure(with: tableView)

// observe viewModel
viewModel.output.selectedRepository
.bind(to: showRepository)
.disposed(by: disposeBag)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ final class RepositoryViewController: SFSafariViewController {

super.init(url: repository.url, configuration: .init())
hidesBottomBarWhenPushed = true

}

override func viewDidLoad() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,17 @@ import RxSwift
import RxCocoa

final class SearchViewController: UIViewController {
@IBOutlet weak var totalCountLabel: UILabel!
@IBOutlet weak var tableView: UITableView!
@IBOutlet weak var tableViewBottomConstraint: NSLayoutConstraint!

private let searchBar = UISearchBar(frame: .zero)
private let loadingView = LoadingView.makeFromNib()
@IBOutlet private(set) weak var totalCountLabel: UILabel!
@IBOutlet private(set) weak var tableView: UITableView!
@IBOutlet private(set) weak var tableViewBottomConstraint: NSLayoutConstraint!

private let dataSource: SearchViewDataSource
private let viewModel: SearchViewModel

let searchBar = UISearchBar(frame: .zero)
let loadingView = LoadingView.makeFromNib()

let viewModel: SearchViewModel
let dataSource: SearchViewDataSource

private let disposeBag = DisposeBag()

Expand All @@ -40,6 +42,7 @@ final class SearchViewController: UIViewController {

navigationItem.titleView = searchBar
searchBar.placeholder = "Input user name"

dataSource.configure(with: tableView)

rx.methodInvoked(#selector(SearchViewController.viewDidAppear(_:)))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ import RxSwift
import RxCocoa

final class UserRepositoryViewController: UIViewController {
@IBOutlet weak var tableView: UITableView!
@IBOutlet weak var totalCountLabel: UILabel!

private let loadingView = LoadingView.makeFromNib()
@IBOutlet private(set) weak var tableView: UITableView!
@IBOutlet private(set) weak var totalCountLabel: UILabel!

private let dataSource: UserRepositoryViewDataSource
private let viewModel: UserRepositoryViewModel
let loadingView = LoadingView.makeFromNib()

let viewModel: UserRepositoryViewModel
let dataSource: UserRepositoryViewDataSource

private let disposeBag = DisposeBag()

Expand All @@ -40,10 +41,10 @@ final class UserRepositoryViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()

dataSource.configure(with: tableView)
title = viewModel.title

// observe viewModel
dataSource.configure(with: tableView)

viewModel.output.showRepository
.bind(to: showRepository)
.disposed(by: disposeBag)
Expand Down