Heimdall PR review smoke#2
Open
maskdotdev wants to merge 13 commits into
Open
Conversation
![heimdall-smoke-maskdotdev[bot]](https://avatars.githubusercontent.com/u/169849706?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| Heimdall PR review smoke. | |||
There was a problem hiding this comment.
Live PR review smoke test
This controlled finding proves the guarded live PR review smoke reached the publisher.
|
Heimdall could not publish every inline review comment, so it is posting the findings here.
|
|
Heimdall could not publish every inline review comment, so it is posting the findings here.
|
| @@ -0,0 +1,3 @@ | |||
| Heimdall PR review smoke. | |||
There was a problem hiding this comment.
Live PR review smoke test
This controlled finding proves the guarded live PR review smoke reached the publisher.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Add an admin-tools smoke command that applies every generated DB migration into an isolated local Postgres schema, verifies the pgcrypto and pgvector extensions, inserts indexed chunk embedding rows, and asserts pgvector nearest-neighbor ordering.\n\nRecord the Phase #2 evidence in PROJECT_STATUS so the live database verification gap is no longer tracked as missing for vector search.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Add MemoryFactRepository with a bounded active review-memory query that applies organization, repository, status, expiration, ordering, and limit rules inside @repo/db. Update review orchestration to use the repository boundary while keeping the validation-specific memory mapping local to the orchestrator. Add Postgres-backed integration coverage for the memory fact query and update the project status notes for the Phase #2 DB-boundary milestone. Verified with focused @repo/db and @repo/review-orchestrator typecheck, lint, and tests, then pnpm check.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move the worker review-thread reconciliation lookup for recent completed review runs behind ReviewRepository. Add a typed recent completed review-run listing method with pull-request filtering, deterministic ordering, and limit validation. Extend review repository integration coverage and refresh PROJECT_STATUS.md for the Phase #2 database boundary milestone. Verification: git diff --check; pnpm --filter @repo/db typecheck; pnpm --filter @repo/db build; pnpm --filter @repo/db lint; pnpm --filter @repo/db test; pnpm --filter @app/worker typecheck; pnpm --filter @app/worker lint; pnpm --filter @app/worker test; pnpm check.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move the worker index-dependency resume lookup for waiting review runs behind ReviewRepository. Add a typed waiting-for-index review-run listing method with deterministic ordering and limit validation. Extend review repository integration coverage, adjust the worker unit stub for ordered repository reads, and refresh PROJECT_STATUS.md for the Phase #2 database boundary milestone. Verification: git diff --check; pnpm --filter @repo/db typecheck; pnpm --filter @repo/db build; pnpm --filter @repo/db lint; pnpm --filter @repo/db test; pnpm --filter @app/worker typecheck; pnpm --filter @app/worker lint; pnpm --filter @app/worker test; pnpm check.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move worker review-artifact cleanup selection and tombstone updates behind ReviewRepository. Add typed cleanup target and payload tombstone repository methods with retention cutoff, repository scope, URI-prefix exclusion, deterministic ordering, and limit validation. Extend review repository integration coverage and refresh PROJECT_STATUS.md for the Phase #2 database boundary milestone. Verification: git diff --check; pnpm --filter @repo/db typecheck; pnpm --filter @repo/db build; pnpm --filter @repo/db lint; pnpm --filter @repo/db test; pnpm --filter @app/worker typecheck; pnpm --filter @app/worker lint; pnpm --filter @app/worker test; pnpm check.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move worker sandbox cleanup target selection, artifact URI reads, and run deletion behind a typed SandboxRepository boundary. Add Postgres-backed integration coverage for repo-scoped cleanup ordering, limit validation, artifact URI lookup, empty delete handling, and cascaded child-row deletion. Update project status for the new Phase #2 sandbox repository milestone. Verification: pnpm exec biome check --write apps/worker/src/index.ts packages/db/src/index.ts packages/db/src/repositories/sandbox-repository.ts packages/db/test/sandbox-repository.integration.test.ts PROJECT_STATUS.md; pnpm --filter @repo/db typecheck; pnpm --filter @app/worker typecheck; pnpm --filter @repo/db lint; pnpm --filter @app/worker lint; pnpm --filter @repo/db test -- sandbox-repository.integration.test.ts; pnpm --filter @app/worker test; git diff --check; pnpm check.
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move product webhook activity count and latest-delivery reads behind WebhookRepository so the API no longer queries webhookEvents directly for onboarding summaries. Add a repository activity summary method with Postgres-backed integration coverage for total deliveries and latest delivery selection. Update the project status notes for the Phase #2 repository boundary progress. Verification: - pnpm exec biome check --write apps/api/src/app.ts packages/db/src/repositories/webhook-repository.ts packages/db/test/webhook-repository.integration.test.ts PROJECT_STATUS.md - pnpm --filter @repo/db typecheck - pnpm --filter @repo/db lint - pnpm --filter @repo/db build - pnpm --filter @app/api typecheck - pnpm --filter @app/api lint - pnpm --filter @app/api test - pnpm --filter @repo/db test -- webhook-repository.integration.test.ts - git diff --check - pnpm check
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Add ProductAuthRepository for product OAuth state persistence, provider account lookup, OAuth user/account upsert, active session reads, membership listing, session revocation, and existing-user checks. Move the API product OAuth/session flows and FK-backed decision user lookup onto the repository boundary instead of directly querying product auth tables. Add Postgres-backed integration coverage for one-time OAuth state consumption, provider identity link preservation, active/expired session reads, membership listing, and revocation. Update the Phase #2 tracker notes for the product auth repository boundary. Verification: - pnpm exec biome check --write apps/api/src/app.ts packages/db/src/index.ts packages/db/src/repositories/product-auth-repository.ts packages/db/test/product-auth-repository.integration.test.ts PROJECT_STATUS.md - pnpm --filter @repo/db typecheck - pnpm --filter @repo/db lint - pnpm --filter @repo/db build - pnpm --filter @app/api typecheck - pnpm --filter @app/api lint - pnpm --filter @repo/db test -- product-auth-repository.integration.test.ts - pnpm --filter @app/api test - git diff --check - pnpm check
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Add SecurityAuditRepository for sensitive artifact access events, idempotent normalized security event writes, and audit log insertion. Move API review-artifact access logging, Postgres security event sink writes, and admin audit writes onto this repository boundary while leaving existing admin list queries unchanged for a later read-side slice. Add Postgres-backed integration coverage for artifact access rows, duplicate security event handling, and inserted audit rows. Update the Phase #2 tracker notes for the security/audit repository boundary. Verification: - pnpm exec biome check --write apps/api/src/app.ts packages/db/src/index.ts packages/db/src/repositories/security-audit-repository.ts packages/db/test/security-audit-repository.integration.test.ts PROJECT_STATUS.md - pnpm --filter @repo/db typecheck - pnpm --filter @repo/db lint - pnpm --filter @repo/db build - pnpm --filter @app/api typecheck - pnpm --filter @app/api lint - pnpm --filter @repo/db test -- security-audit-repository.integration.test.ts - pnpm --filter @app/api test - git diff --check - pnpm check
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Extend SecurityAuditRepository with filtered audit-log and security-event listing, including deterministic ordering and bounded-list validation. Move the API admin audit and security inspection reads onto the repository boundary so apps/api no longer imports the audit_logs or security_events schema tables directly. Expand Postgres-backed integration coverage for filtered searches, list ordering, and invalid limits. Update the Phase #2 tracker notes for the read-side security/audit repository progress. Verification: - pnpm exec biome check --write apps/api/src/app.ts packages/db/src/repositories/security-audit-repository.ts packages/db/test/security-audit-repository.integration.test.ts PROJECT_STATUS.md - pnpm --filter @repo/db typecheck - pnpm --filter @repo/db lint - pnpm --filter @repo/db build - pnpm --filter @app/api typecheck - pnpm --filter @app/api lint - pnpm --filter @repo/db test -- security-audit-repository.integration.test.ts - pnpm --filter @app/api test - git diff --check - pnpm check
maskdotdev
added a commit
that referenced
this pull request
May 8, 2026
Move API billing meter debug reads, stale and failed meter reconciliation reads, and failed billing webhook issue reads behind BillingRepository. Add repository record types and Postgres-backed integration coverage for meter-event filters, stale and failed sync issue selection, failed webhook ordering, and bounded list validation. Update Phase #2 notes for the expanded billing repository boundary. Verification: - pnpm exec biome check --write apps/api/src/app.ts packages/db/src/repositories/billing-repository.ts packages/db/test/billing-repository.integration.test.ts PROJECT_STATUS.md - pnpm --filter @repo/db typecheck - pnpm --filter @repo/db lint - pnpm --filter @repo/db build - pnpm --filter @app/api typecheck - pnpm --filter @app/api lint - pnpm --filter @repo/db test -- billing-repository.integration.test.ts - pnpm --filter @app/api test - git diff --check - pnpm check
maskdotdev
added a commit
that referenced
this pull request
May 10, 2026
Add an AdminDebugRepository boundary for privileged admin action, debug export, replay run, and replay stage persistence. Wire admin tooling job cancellation, debug bundle export, eval import draft audit rows, and replay dispatch history through that repository instead of raw table inserts. Add Postgres-backed integration coverage for the repository and update project status to record the narrowed Phase #2 database seam. Validate the slice with focused package checks and full pnpm check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR used by the guarded Heimdall live PR review smoke.