Skip to content

fix: accept pull request webhooks without installation accounts#3

Merged
maskdotdev merged 1 commit into
mainfrom
heimdall/pull-request-webhook-account-fallback
May 9, 2026
Merged

fix: accept pull request webhooks without installation accounts#3
maskdotdev merged 1 commit into
mainfrom
heimdall/pull-request-webhook-account-fallback

Conversation

@maskdotdev
Copy link
Copy Markdown
Owner

Summary

  • fall back to repository.owner when GitHub pull_request webhooks omit installation.account
  • preserve deterministic installation/org normalization for valid pull_request.synchronize deliveries
  • add a regression test for the observed payload shape from the Heimdall GitHub App delivery log

Verification

  • pnpm --filter @repo/webhook-ingestion lint
  • pnpm --filter @repo/webhook-ingestion typecheck
  • pnpm --filter @repo/webhook-ingestion test -- github-normalize.test.ts
  • pnpm check

GitHub pull_request deliveries can omit installation.account while still including repository.owner. Use the repository owner as the installation account fallback during normalization so valid pull_request.synchronize events do not fail with a webhook.invalid_payload response.\n\nAdd a regression test that mirrors that payload shape and keep fixture owner metadata aligned with GitHub's owner object.
@maskdotdev maskdotdev merged commit 18ec4bc into main May 9, 2026
0 of 2 checks passed
@railway-app railway-app Bot temporarily deployed to sublime-blessing / production May 9, 2026 03:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant