Skip to content

Python types: mutable-immutable#3548

Open
Akvilegia83 wants to merge 22 commits into
mate-academy:masterfrom
Akvilegia83:solution
Open

Python types: mutable-immutable#3548
Akvilegia83 wants to merge 22 commits into
mate-academy:masterfrom
Akvilegia83:solution

Conversation

@Akvilegia83
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your code correctly defines all 8 variables of different types, but the core requirement is missing. The task explicitly requires creating a sorted_variables dictionary with 'mutable' and 'immutable' keys, where each value is a list of the corresponding variable types. This dictionary is not present anywhere in your code. You need to add something like:

sorted_variables = {
    'mutable': [students, fruits, user],
    'immutable': [count_people, price, is_empty, message, marks]
}

Make sure to use the exact variable names you defined (count_people, price, is_empty, message, marks, students, fruits, user) and place this dictionary in the main() function. Once you add this dictionary, your implementation should be complete.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The request meets the required criteria.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py Outdated
Comment on lines +20 to +22
sorted_variables = {
"mutable": [profile_info, collection_of_coins, students, fruits, user],
"immutable": [count_people, is_empty, marks, message, price]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuples are mutable in Python (e.g., marks[0] = 1 works), so marks should be moved to the 'mutable' list instead of 'immutable'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants