fix(radio): dispatch input event on keyboard navigation#5983
Open
ErnestHysa wants to merge 1 commit into
Open
Conversation
Fixes material-components#5949 Dispatch an InputEvent before the change event when keyboard-navigating radio buttons with arrow keys, matching native <input type='radio'> behavior where both input and change events fire on user interaction. Added test to verify input event is dispatched on keyboard navigation.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5949
Dispatches an
InputEventbefore thechangeevent when keyboard-navigating radio buttons with arrow keys, matching native<input type='radio'>behavior where bothinputandchangeevents fire on user interaction.Changes
SingleSelectionController.handleKeyDowninradio/internal/single-selection-controller.tsto dispatch anInputEventbefore thechangeeventradio/radio_test.tsto verifyinputevent is dispatched on keyboard navigationTesting
Added a new test case
dispatched an input event on user navigationthat verifies theinputevent is fired when using arrow keys to navigate radio buttons.