Make functions prefixed with _ but cross-imported public
#767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefix "_" indicates private but cross-imported means de facto public
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 76.56% 76.56% -0.01%
==========================================
Files 114 114
Lines 8478 8477 -1
Branches 1274 1273 -1
==========================================
- Hits 6491 6490 -1
Misses 1600 1600
Partials 387 387
|
janosh
changed the title
_ but cross-imported_ but cross-imported public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefix "_" indicates private but cross-imported means de facto public.
strictly speaking breaking if downstream code was importing these private symbols but given they were marked private there was no expectation of stability.