Cache routes only when caching enabled#849
Closed
tsteur wants to merge 1 commit into
Closed
Conversation
I pulled the latest changes from Git recently and whenever I open the changelog page locally, it would render the trac page. After a quick debug session noticed that the routes are cached despite caching disabled. I assume that this cache shouldn't be set unless caching is actually enabled. Might also give a performance update on production
Contributor
|
There is already a PR for this with a discussion #842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled the latest changes from Git recently and whenever I open the changelog page locally, it would render the trac page. After a quick debug session noticed that the routes are cached despite caching disabled. I assume that this cache shouldn't be set unless caching is actually enabled. Might also give a performance update on production
Review