ci: Fix release publishing#37
Merged
Merged
Conversation
The top-level `env` is not available as an `env` context directly, and apparently jobs outputs is the best way to do this.
efiring
approved these changes
Sep 6, 2023
efiring
left a comment
efiring
left a comment
Member
There was a problem hiding this comment.
I can't judge these machinery changes in detail, but they don't touch policy, so there is no reason to require multiple approvals.
story645
approved these changes
Sep 7, 2023
Member
|
@efiring the way the rules are written, I think any 3 matplotib maintainers can approve and it'll lift the block-as far as I can tell the branch protection rule isn't min3(steering-council), especially since there isn't a defined steering council role - but also i think that branch protection rule can be edited so that anyone on the steering council can override it for these kinda situations. |
dopplershift
approved these changes
Sep 7, 2023
Member
Author
|
This successfully published again https://github.com/matplotlib/governance/actions/runs/6113109840/job/16591941977#step:7:134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can see in the latest build on
mainthat the Publish step did not run, which broke due to my change in #34. The top-levelenvis not available as anenvcontext directly, and apparently jobs outputs is the best way to do this.Once that is fixed, it turns out that the Analytics is broken, so I updated it to use Plausible, which is now working and publishing on
main, and publishing is skipped on other branches.The workflow is also complaining that "The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/" so I've updated checkout to v4.