Fix nix linkage issues#275
Merged
Merged
Conversation
x86pup
force-pushed
the
june-msrv
branch
2 times, most recently
from
32fa2f8 to
3901204
Compare
13 tasks
Contributor
|
What does this PR fix? Context: We're doing the 1.4.9.1->1.5.0 version bump in nixpkgs and I'm trying to figure out if we need these changes as well. The server seems to work fine without them and I can't figure out what "runpath" refers to here. |
Contributor
Author
|
This is related to the MSRV bump After switching versions the binary stopped linking itself to libs, so I had to link it by hand. You probably don't need to port this in any way because nixpkgs already been building with new rust versions |
Contributor
|
Got it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, after MSRV bump all the runpath stuff stopped writing itself to the binary. This adds mechanisms to put them back.
Would love for someone to fix that wihtout autoPatchelf for cleaner code.