Fix and rename media delete range#375
Merged
Merged
Conversation
Fixes incorrectly treated bounds in the media range deletion command, by disallowing the use of the command without specifying a range as well as flipping the bounds check so that it now deletes the correct range. Since users use this command and the behavior is opposite of what it used to be, the command and its arguments were both renamed to avoid accidental deletion of media. The documentation was also updated to remove the erroneous suggestion that the file's creation time is considered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrectly treated bounds in the media range deletion command, by disallowing the use of the command without specifying a range as well as flipping the bounds check so that it now deletes the correct range.
Since users use this command and the behavior is opposite of what it used to be, the command and its arguments were both renamed to avoid accidental deletion of media. The documentation was also updated to remove the erroneous suggestion that the file's creation time is considered.