Add a test for restricted rooms appearing in the spaces summary (MSC3083).#109
Add a test for restricted rooms appearing in the spaces summary (MSC3083).#109
Conversation
…ooms-in-space-summary
…ooms-in-space-summary
|
As with other PRs, we'll need to wait for a release before this will pass CI. |
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
The tests look correct from a functional standpoint. I just had a couple questions as someone who's been outside the world of Spaces implementation up until recently.
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Definitely better! One last question (and a couple corrections).
tests/msc3083_test.go
Outdated
| // charlie joins the space and now hs2 knows that alice is in the space (and | ||
| // can join room). |
There was a problem hiding this comment.
My main question revolves around why hs2 needs to know alice can join the room if we're asking hs1 for the space summary. hs1 knows alice can join the room already.
My assumption is that hs1 needs to ask hs2 this question, but it'd be good to mention that.
There was a problem hiding this comment.
Ah, hs1 is asking hs2 about "room" while generating the summary. I'll add this.
There was a problem hiding this comment.
I updated the docstring which talks about the setup of space/room, I hope that's OK. The above is true for every time we attempt to summarize so that seemed like the best spot.
There was a problem hiding this comment.
Thanks! And aha, I think my mental model had Alice creating the room, not Charlie, that's why I was confused about why hs1 didn't know about the status of the room.
That realisation and the additional notes make things fairly clear now, thanks!
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
3 participants
This adds some additional tests for MSC3083 for ensuring that the space summary works for restricted rooms.
See matrix-org/synapse#9922 for the Synapse implementation.