Skip to content

Move MakeLeave to GMSL#385

Merged
S7evinK merged 1 commit intomainfrom
s7evink/makeleave
May 23, 2023
Merged

Move MakeLeave to GMSL#385
S7evinK merged 1 commit intomainfrom
s7evink/makeleave

Conversation

@S7evinK
Copy link
Collaborator

@S7evinK S7evinK commented May 23, 2023

Mostly copy & paste from MakeJoin

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.31 🎉

Comparison is base (b92e84b) 55.26% compared to head (faf081b) 55.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   55.26%   55.57%   +0.31%     
==========================================
  Files          43       44       +1     
  Lines        6364     6409      +45     
==========================================
+ Hits         3517     3562      +45     
  Misses       2510     2510              
  Partials      337      337              
Impacted Files Coverage Δ
handleleave.go 93.33% <93.33%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit 3fddabe into main May 23, 2023
@S7evinK S7evinK deleted the s7evink/makeleave branch May 23, 2023 16:40
S7evinK added a commit to matrix-org/dendrite that referenced this pull request May 23, 2023
Basically the same API shape as for `/make_join`
matrix-org/gomatrixserverlib#385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants